feat: expand image processing options#228
Open
LeviSnoot wants to merge 1 commit intoJustRadical:mainfrom
Open
Conversation
Contributor
Author
|
@radiicall I believe the checks are only failing due to this: https://github.com/Radiicall/jellyfin-rpc/blob/92677b337cb80e2e882b7c9fb182e3d475b82720/jellyfin-rpc-cli/Cargo.toml#L32 I left it alone in this commit as I'm not sure if there's an external dependency on it, but when I uncomment this and compile it works just fine. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought the image processing could do with some user configuration and increased flexibility.
images.bg = false. This option keeps the 1:1 canvas, but has no background, makes it look more native to Discord:images.bg_blur, default set to 3%.images.bgisfalse, rounded corners are automatically applied to the image. The amount can be set usingimages.corner_radius. Default is 4%.Some examples for various configurations:
Default:
{ "images": { "bg": true, "bg_blur": 3 } }Reduced image size:
{ "images": { "size": 512, "bg": true, "bg_blur": 3 } }Increased blur value:
{ "images": { "size": 512, "bg": true, "bg_blur": 15 } }Disabled background, default corner radius:
{ "images": { "size": 512, "bg": false, "corner_radius": 4 } }Increased corner radius:
{ "images": { "size": 512, "bg": false, "corner_radius": 10 } }No rounded corners:
{ "images": { "size": 512, "bg": false, "corner_radius": 0 } }